Simplify REPL #3560
Merged
Simplify REPL #3560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove monadic API when not needed: methods returning `Result[T]` now return `T` if failure is not possible - Other minor polishing
allanrenucci
force-pushed
the
topic/repl
branch
from
cc8ab97 to
a1c776d
Compare
felixmulder
approved these changes
Nov 27, 2017
| val B: List[Int] = Nil | ||
| val C: List[Int] = Nil | ||
| val B: List[Int] = List() | ||
| val C: List[Int] = List() |
| @@ -72,12 +73,12 @@ object Show { | |||
|
|
|||
| implicit def showList[T](implicit st: Show[T]): Show[List[T]] = new Show[List[T]] { | |||
| def show(xs: List[T]) = | |||
| if (xs.isEmpty) "Nil" | |||
| if (xs.isEmpty) "List()" | |||
| else "List(" + xs.map(_.show).mkString(", ") + ")" | ||
| } | ||
|
|
||
| implicit val showNil: Show[Nil.type] = new Show[Nil.type] { | ||
| def show(xs: Nil.type) = "Nil" | ||
| def show(xs: Nil.type) = "List()" |
There was a problem hiding this comment.
It is what scalac does:
scala> List()
res0: List[Nothing] = List()
scala> List(1, 2)
res1: List[Int] = List(1, 2)I think it is more consistent
There was a problem hiding this comment.
¯\__(ツ)_/¯
Sounds like a debate for the ages. I'm definitely fine with the change, just wanted to know if there was some other motive beside the superficial one :)
There was a problem hiding this comment.
Purely superficial =)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result[T]now returnTif failure is not possible